github-vet / github-vet/rangeloop-pointer-findings
cloudfoundry-attic/storeadapter: fakestoreadapter/fakestoreadapter.go; 37 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cloudfoundry-attic/storeadapter](https://www.github.com/cloudfoundry-attic/storeadapter) at [fakestoreadapter/fakestoreadapter.go](https://github.com/cloudfoundry-attic/storeadapter/blob/6ec3e4f28fe774137a16eace9311bca448d44bee/fakestoreadapter/fakestoreadapter.go#L138-L174)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to node at line 173 may start a goroutine
[Click here to see the code in its original context.](https://github.com/cloudfoundry-attic/storeadapter/blob/6ec3e4f28fe774137a16eace9311bca448d44bee/fakestoreadapter/fakestoreadapter.go#L138-L174)
Click here to show the 37 line(s) of Go which triggered the analyzer.
```go
for _, node := range nodes {
prevNode, err := adapter.get(node.Key)
if err == nil {
eventType = storeadapter.UpdateEvent
} else {
eventType = storeadapter.CreateEvent
}
if adapter.SetErrInjector != nil && adapter.SetErrInjector.KeyRegexp.MatchString(node.Key) {
return adapter.SetErrInjector.Error
}
components := adapter.keyComponents(node.Key)
container := adapter.rootNode
for i, component := range components {
existingNode, exists := container.nodes[component]
if i == len(components)-1 {
if exists && existingNode.dir {
return storeadapter.NewError(errors.New(storeadapter.ErrorNodeIsDirectoryDescription), storeadapter.ErrorNodeIsDirectory)
}
container.nodes[component] = &containerNode{storeNode: node}
} else {
if exists {
if !existingNode.dir {
return storeadapter.NewError(errors.New(storeadapter.ErrorNodeIsNotDirectoryDescription), storeadapter.ErrorNodeIsNotDirectory)
}
container = existingNode
} else {
newContainer := &containerNode{dir: true, nodes: make(map[string]*containerNode)}
container.nodes[component] = newContainer
container = newContainer
}
}
}
adapter.sendEvent(&prevNode, &node, eventType)
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(sendEvent, 3)" -> {}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6ec3e4f28fe774137a16eace9311bca448d44bee
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.