github-vet / github-vet/rangeloop-pointer-findings

aclindsa/moneygo: internal/handlers/imports.go; 27 LoC

Open
#11,478 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [aclindsa/moneygo](https://www.github.com/aclindsa/moneygo) at [internal/handlers/imports.go](https://github.com/aclindsa/moneygo/blob/285b6322392d7ea8459c8ce6446ca6b1bf7a0696/internal/handlers/imports.go#L150-L176)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/aclindsa/moneygo/blob/285b6322392d7ea8459c8ce6446ca6b1bf7a0696/internal/handlers/imports.go#L150-L176)

Click here to show the 27 line(s) of Go which triggered the analyzer.

```go
for imbalanced_security, imbalance := range imbalances {
if imbalance.Cmp(&zero) != 0 {
imbalanced_account, err := GetImbalanceAccount(tx, user.UserId, imbalanced_security)
if err != nil {
log.Print(err)
return NewError(999 /*Internal Error*/)
}

// Add new split to fixup imbalance
split := new(models.Split)
r := new(big.Rat)
r.Neg(&imbalance)
security, err := tx.GetSecurity(imbalanced_security, user.UserId)
if err != nil {
log.Print(err)
return NewError(999 /*Internal Error*/)
}
split.Amount.Rat = *r
if split.Amount.Precision() > security.Precision {
log.Printf("Precision on created imbalance-correction split (%d) greater than the underlying security (%s) allows (%d)", split.Amount.Precision(), security, security.Precision)
return NewError(999 /*Internal Error*/)
}
split.SecurityId = -1
split.AccountId = imbalanced_account.AccountId
transaction.Splits = append(transaction.Splits, split)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Neg 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 285b6322392d7ea8459c8ce6446ca6b1bf7a0696

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with internal/handlers/imports.go lines 150-176 and trace GetImbalanceAccount, tx.GetSecurity, and the analyzer's reported pointer flow. Determine whether the range variable reference can cause incorrect behavior, then classify the finding as Bug, Mitigated, or Desirable Behavior using the linked project guidance; no test or specific code change is named.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.