github-vet / github-vet/rangeloop-pointer-findings

chrislusf/glow: driver/scheduler/scheduler_execute.go; 12 LoC

Open
#11,454 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [chrislusf/glow](https://www.github.com/chrislusf/glow) at [driver/scheduler/scheduler_execute.go](https://github.com/chrislusf/glow/blob/4c40a2717eee6512247ce30ab8a8428348d6d9e9/driver/scheduler/scheduler_execute.go#L114-L125)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable out used in defer or goroutine at line 121

[Click here to see the code in its original context.](https://github.com/chrislusf/glow/blob/4c40a2717eee6512247ce30ab8a8428348d6d9e9/driver/scheduler/scheduler_execute.go#L114-L125)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for _, out := range ds.ExternalOutputChans {
ch := make(chan reflect.Value)
netchan.ConnectRawReadChannelToTyped(rawChan, ch, ds.Type, waitGroup)
waitGroup.Add(1)
go func() {
defer waitGroup.Done()
for v := range ch {
v = netchan.CleanObject(v, ds.Type, out.Type().Elem())
out.Send(v)
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4c40a2717eee6512247ce30ab8a8428348d6d9e9

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.