github-vet / github-vet/rangeloop-pointer-findings
elodina/go_kafka_client: fetcher.go; 16 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [elodina/go_kafka_client](https://www.github.com/elodina/go_kafka_client) at [fetcher.go](https://github.com/elodina/go_kafka_client/blob/95d107b0c102fa81b8c1e5e556adc23352fad065/fetcher.go#L333-L348)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/elodina/go_kafka_client/blob/95d107b0c102fa81b8c1e5e556adc23352fad065/fetcher.go#L333-L348)
Click here to show the 16 line(s) of Go which triggered the analyzer.
```go
for topicAndPartition, info := range partitionTopicInfos {
if _, contains := f.partitionMap[topicAndPartition]; !contains {
f.partitionMap[topicAndPartition] = info
validOffset := info.FetchedOffset + 1
if isOffsetInvalid(info.FetchedOffset) {
f.handleOffsetOutOfRange(&topicAndPartition)
} else {
f.partitionMap[topicAndPartition].FetchedOffset = validOffset
}
f.partitionMap[topicAndPartition].Buffer.start(f.askNext)
newPartitions[topicAndPartition] = f.askNext
if Logger.IsAllowed(DebugLevel) {
Debugf(f, "Owner of %s", topicAndPartition)
}
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {handleOffsetOutOfRange 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 95d107b0c102fa81b8c1e5e556adc23352fad065
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect fetcher.go at lines 333-348 and review the linked analyzer context, especially the call to handleOffsetOutOfRange. Determine whether the range-loop pointer finding represents a bug, mitigated behavior, or desirable behavior, then record the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kafka
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100