github-vet / github-vet/rangeloop-pointer-findings
LemoFoundationLtd/lemochain-core: network/protocol_manager.go; 17 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [LemoFoundationLtd/lemochain-core](https://www.github.com/LemoFoundationLtd/lemochain-core) at [network/protocol_manager.go](https://github.com/LemoFoundationLtd/lemochain-core/blob/949f3ebb03c7ebd25687937152f619a1e3fa99e4/network/protocol_manager.go#L788-L804)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable tx used in defer or goroutine at line 796
[Click here to see the code in its original context.](https://github.com/LemoFoundationLtd/lemochain-core/blob/949f3ebb03c7ebd25687937152f619a1e3fa99e4/network/protocol_manager.go#L788-L804)
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go
for _, tx := range txs {
if err := tx.VerifyTxBody(pm.chainID, nowTime, false); err != nil {
continue
}
go func() {
// 判断接收到的交易是否在本分支已经存在
currentBlock := pm.chain.CurrentBlock()
isExist := pm.txGuard.ExistTx(currentBlock.Hash(), tx)
if !isExist {
if err := pm.txPool.AddTx(tx); err == nil { // 加入交易池
// 广播交易
subscribe.Send(subscribe.NewTx, tx)
}
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 949f3ebb03c7ebd25687937152f619a1e3fa99e4
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.