github-vet / github-vet/rangeloop-pointer-findings

nd-sin/go-by-tdd: concurrency/v3/site_checker.go; 11 LoC

Open
#11,331 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [nd-sin/go-by-tdd](https://www.github.com/nd-sin/go-by-tdd) at [concurrency/v3/site_checker.go](https://github.com/nd-sin/go-by-tdd/blob/26487b92ca40e5f4d28abcd21f7efdc8a76453ac/concurrency/v3/site_checker.go#L8-L18)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable url used in defer or goroutine at line 16

[Click here to see the code in its original context.](https://github.com/nd-sin/go-by-tdd/blob/26487b92ca40e5f4d28abcd21f7efdc8a76453ac/concurrency/v3/site_checker.go#L8-L18)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for _, url := range urls {
// buradaki sorun urls'den her donguge url'e bir deger ataniyor
// ama biz her goroutine ayni referance a sahip url'i veriyoruz
// her birine kendi kopyasini "vermiyoruz".
// bu yuzden url iteration'in sonunda son url'e sahip oluyor.
// bu yuzden elimizdeki tek sonuc son
// bunu duzeltelim
go func() {
results[url] = wc(url)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 26487b92ca40e5f4d28abcd21f7efdc8a76453ac

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.