github-vet / github-vet/rangeloop-pointer-findings
gtyrin/go_ds: service/audio/metadata_manager/cmd/command.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [gtyrin/go_ds](https://www.github.com/gtyrin/go_ds) at [service/audio/metadata_manager/cmd/command.go](https://github.com/gtyrin/go_ds/blob/167b4a8c8dc3649034384f157d1fc144ba6522d9/service/audio/metadata_manager/cmd/command.go#L181-L190)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 187 passes reference to entry to third-party code
[Click here to see the code in its original context.](https://github.com/gtyrin/go_ds/blob/167b4a8c8dc3649034384f157d1fc144ba6522d9/service/audio/metadata_manager/cmd/command.go#L181-L190)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, entry := range entries {
album, err := cmd.albumInfo(entry.Path)
if err != nil {
log.Error(err)
continue
}
if cmd.CheckDirAndFix(&entry, album) {
cmd.RecalcDirMetadata(entry.Path, true)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(UpdateIdentifierFlag, 1)" -> {}
"(UpdateMandatoryFlag, 1)" -> {}
"(CheckDirAndFix, 2)" -> {"(UpdateIdentifierFlag, 1)";"(UpdateMandatoryFlag, 1)";}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 167b4a8c8dc3649034384f157d1fc144ba6522d9
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.