github-vet / github-vet/rangeloop-pointer-findings
VictorSnow/go-gfw-dns: dns.go; 22 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [VictorSnow/go-gfw-dns](https://www.github.com/VictorSnow/go-gfw-dns) at [dns.go](https://github.com/VictorSnow/go-gfw-dns/blob/eec14afd0445c8a9e6cdba37c69c9d5fdc81c641/dns.go#L73-L94)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable s used in defer or goroutine at line 84
[Click here to see the code in its original context.](https://github.com/VictorSnow/go-gfw-dns/blob/eec14afd0445c8a9e6cdba37c69c9d5fdc81c641/dns.go#L73-L94)
Click here to show the 22 line(s) of Go which triggered the analyzer.
```go
for _, s := range server {
wg.Add(1)
go func() {
defer wg.Done()
c := &dns.Client{
Net: "udp",
ReadTimeout: DNS_TIMEOUT,
WriteTimeout: DNS_TIMEOUT,
DialTimeout: DNS_TIMEOUT,
}
r, _, err := c.Exchange(req, s)
if err != nil {
return
}
select {
case recvChan <- r:
default:
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: eec14afd0445c8a9e6cdba37c69c9d5fdc81c641
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.