github-vet / github-vet/rangeloop-pointer-findings

baidu/ote-stack: pkg/syncer/syncer.go; 30 LoC

Open
#11,273 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [baidu/ote-stack](https://www.github.com/baidu/ote-stack) at [pkg/syncer/syncer.go](https://github.com/baidu/ote-stack/blob/afc7ae1e6419f63aa229a019674232b2878c6cd2/pkg/syncer/syncer.go#L256-L285)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable factory used in defer or goroutine at line 264

[Click here to see the code in its original context.](https://github.com/baidu/ote-stack/blob/afc7ae1e6419f63aa229a019674232b2878c6cd2/pkg/syncer/syncer.go#L256-L285)

Click here to show the 30 line(s) of Go which triggered the analyzer.

```go
for name, factory := range ctx.InformerFactory {
factory.Start(ctx.StopChan)
// wait for all caches to sync.
finishChan := make(chan bool)

go func() {
isSyncFinish := true

syncedMap := factory.WaitForCacheSync(ctx.StopChan)
for informerType, isSync := range syncedMap {
if !isSync {
isSyncFinish = false
klog.Errorf("informer for %s hasn't synced", informerType.String())
break
}
}
finishChan <- isSyncFinish
}()

select {
case isSyncerDone := <-finishChan:
if !isSyncerDone {
return fmt.Errorf("start syncer informer factory failed: %s hasn't synced", name)
}
case <-time.After(time.Second * time.Duration(ctx.SyncTimeout)):
return fmt.Errorf("start syncer informer factory failed: %s synced timeout", name)
}

klog.V(2).Infof("start %s success", name)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: afc7ae1e6419f63aa229a019674232b2878c6cd2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.