github-vet / github-vet/rangeloop-pointer-findings
phil0522/znote: pkg/subcommands/editnote.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [phil0522/znote](https://www.github.com/phil0522/znote) at [pkg/subcommands/editnote.go](https://github.com/phil0522/znote/blob/abc261fad9ecbede5077e590b1e7b0f007a52992/pkg/subcommands/editnote.go#L33-L42)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable book used in defer or goroutine at line 36
[Click here to see the code in its original context.](https://github.com/phil0522/znote/blob/abc261fad9ecbede5077e590b1e7b0f007a52992/pkg/subcommands/editnote.go#L33-L42)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, book := range market.Books {
if book.Notes.HasNoteById(noteId) {
go func() {
note := book.Notes.GetNote(noteId)
book.EditNote(note)
market.SaveAll()
maybeSubmit()
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: abc261fad9ecbede5077e590b1e7b0f007a52992
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.