github-vet / github-vet/rangeloop-pointer-findings
titagaki/peercast-yayp: job/sync_channel.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [titagaki/peercast-yayp](https://www.github.com/titagaki/peercast-yayp) at [job/sync_channel.go](https://github.com/titagaki/peercast-yayp/blob/de73faa24061123b0ff0b34f99596f6c303f855e/job/sync_channel.go#L50-L60)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to host is reassigned at line 58
[Click here to see the code in its original context.](https://github.com/titagaki/peercast-yayp/blob/de73faa24061123b0ff0b34f99596f6c303f855e/job/sync_channel.go#L50-L60)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, host := range v.ChanHitStat.ChanHit {
if host.Push == true {
continue
}
if host.Tracker == true {
tracker = &host
break
} else if tracker == nil {
tracker = &host
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: de73faa24061123b0ff0b34f99596f6c303f855e
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with job/sync_channel.go lines 50-60 at commit de73faa24061123b0ff0b34f99596f6c303f855e and inspect how the range-loop variable host is referenced. Determine whether the analyzer's reported reassignment is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100