github-vet / github-vet/rangeloop-pointer-findings

Oringik/DreamTeam-production: goserver/notification/org_join_req_accepted.go; 7 LoC

Open
#11,166 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Oringik/DreamTeam-production](https://www.github.com/Oringik/DreamTeam-production) at [goserver/notification/org_join_req_accepted.go](https://github.com/Oringik/DreamTeam-production/blob/a46cccb8e3b76985627ee1be0998554a689edfb0/goserver/notification/org_join_req_accepted.go#L27-L33)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to member is reassigned at line 32

[Click here to see the code in its original context.](https://github.com/Oringik/DreamTeam-production/blob/a46cccb8e3b76985627ee1be0998554a689edfb0/goserver/notification/org_join_req_accepted.go#L27-L33)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, member := range req.Request.Organization.Admins.Members {
if member.UserID == *req.Request.AcceptorID {
continue
}

mems[member.ID] = &member
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a46cccb8e3b76985627ee1be0998554a689edfb0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.