sapcc/kubernetes-operators: openstack-seeder/pkg/seeder/apis/v1/types.go; 57 LoC

Found a possible issue in [sapcc/kubernetes-operators](https://www.github.com/sapcc/kubernetes-operators) at [openstack-seeder/pkg/seeder/apis/v1/types.go](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L624-L680)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L624-L680)

Click here to show the 57 line(s) of Go which triggered the analyzer.

```go
for i, v := range e.Projects {
if v.Name == project.Name {
glog.V(2).Info("merge project ", project)
utils.MergeStructFields(&v, project)
if project.NetworkQuota != nil {
if v.NetworkQuota == nil {
v.NetworkQuota = new(NetworkQuotaSpec)
}
utils.MergeStructFields(v.NetworkQuota, project.NetworkQuota)
}
if len(project.RoleAssignments) > 0 {
v.MergeRoleAssignments(project)
}
if len(project.Endpoints) > 0 {
v.MergeEndpoints(project)
}
if len(project.AddressScopes) > 0 {
v.MergeAddressScopes(project)
}
if len(project.SubnetPools) > 0 {
v.MergeSubnetPools(project)
}
if len(project.Networks) > 0 {
v.MergeNetworks(project)
}
if len(project.Routers) > 0 {
v.MergeRouters(project)
}
if project.Swift != nil {
v.MergeSwiftAccount(project)
}
if project.DNSQuota != nil {
if v.DNSQuota == nil {
v.DNSQuota = new(DNSQuotaSpec)
}
utils.MergeStructFields(v.DNSQuota, project.DNSQuota)
}
if len(project.DNSZones) > 0 {
v.MergeDNSZones(project)
}
if len(project.DNSTSIGKeys) > 0 {
v.MergeDNSTSIGKeys(project)
}
if len(project.Ec2Creds) > 0 {
v.MergeEc2Creds(project)
}
if len(project.Flavors) > 0 {
v.Flavors = utils.MergeStringSlices(v.Flavors, project.Flavors)
}
if len(project.ShareTypes) > 0 {
v.ShareTypes = utils.MergeStringSlices(v.ShareTypes, project.ShareTypes)
}
e.Projects[i] = v
found = true
break
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {MergeStructFields 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd

Start with openstack-seeder/pkg/seeder/apis/v1/types.go around lines 624-680 and inspect the MergeStructFields call in the project merge loop. Trace how the referenced value is used and determine whether the analyzer finding changes behavior. Done means classifying the finding as a bug, mitigated, or desirable behavior, with supporting evidence.

Written by the indexing model from the issue text.