zooter68/juju4U: provider/openstack/legacy_networking.go; 12 LoC

Found a possible issue in [zooter68/juju4U](https://www.github.com/zooter68/juju4U) at [provider/openstack/legacy_networking.go](https://github.com/zooter68/juju4U/blob/a0d745913c35e47c33dc13f0230ee55d9a0e021a/provider/openstack/legacy_networking.go#L31-L42)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to fip is reassigned at line 32

[Click here to see the code in its original context.](https://github.com/zooter68/juju4U/blob/a0d745913c35e47c33dc13f0230ee55d9a0e021a/provider/openstack/legacy_networking.go#L31-L42)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for _, fip := range fips {
newfip = &fip
if fip.InstanceId != nil && *fip.InstanceId != "" {
// unavailable, skip
newfip = nil
continue
} else {
logger.Debugf("found unassigned public ip: %v", newfip.IP)
// unassigned, we can use it
return &newfip.IP, nil
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a0d745913c35e47c33dc13f0230ee55d9a0e021a

Inspect provider/openstack/legacy_networking.go at lines 31-42 and read the surrounding range over fips. Determine whether the returned pointer can refer to the loop variable rather than the intended address, then verify the finding against the repository's available checks or tests. Done means the pointer behavior is intentional or corrected and the analyzer finding is classified accordingly.

Written by the indexing model from the issue text.