github-vet / github-vet/rangeloop-pointer-findings

fredericalix/yic_workflow: server/rabbitmq.go; 43 LoC

Open
#11,059 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [fredericalix/yic_workflow](https://www.github.com/fredericalix/yic_workflow) at [server/rabbitmq.go](https://github.com/fredericalix/yic_workflow/blob/3958593a77bd040907c480d649887f4f999e8e5c/server/rabbitmq.go#L199-L241)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable sid used in defer or goroutine at line 230

[Click here to see the code in its original context.](https://github.com/fredericalix/yic_workflow/blob/3958593a77bd040907c480d649887f4f999e8e5c/server/rabbitmq.go#L199-L241)

Click here to show the 43 line(s) of Go which triggered the analyzer.

```go
for sid, out := range output {
out["created_at"] = now
body, err := json.Marshal(out)
if err != nil {
log.Println(err)
continue
}

log.Printf("send %v.%v: %s\n", aid, sid, body)

err = senbSensor.Publish(
"sensors", // exchange
aid+"."+sid, // routing key
false, // mandatory
false, // immediate
amqp.Publishing{
DeliveryMode: amqp.Persistent,
// CorrelationId: coorID,
Headers: amqp.Table{"timestamp": now},
ContentType: "application/json",
Body: body,
})
if err != nil {
log.Println(err)
}

// send webhook if it exist
if url, exist := w.Hooks[sid]; exist {
go func() {
resp, err := http.Post(url, "application/json", bytes.NewReader(body))
if err != nil {
log.Printf("cannot send webhood for %s.%s: %v\n", aid, sid, err)
return
}
defer resp.Body.Close()
if resp.StatusCode/100 != 2 {
log.Printf("cannot send webhood for %s.%s: %v\n", aid, sid, resp.Status)
return
}
log.Printf("send webhook %v.%v to %s\n", aid, sid, url)
}()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3958593a77bd040907c480d649887f4f999e8e5c

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.