docker/deploykit: pkg/plugin/instance/image/instance.go; 53 LoC

Found a possible issue in [docker/deploykit](https://www.github.com/docker/deploykit) at [pkg/plugin/instance/image/instance.go](https://github.com/docker/deploykit/blob/41da4a601bbb18514c61ebaed12a229098ddcd3e/pkg/plugin/instance/image/instance.go#L351-L403)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to id was used in a composite literal at line 393

[Click here to see the code in its original context.](https://github.com/docker/deploykit/blob/41da4a601bbb18514c61ebaed12a229098ddcd3e/pkg/plugin/instance/image/instance.go#L351-L403)

Click here to show the 53 line(s) of Go which triggered the analyzer.

```go
for id, parts := range items {

all := []map[string]string{}
lid := ""
for _, p := range parts {
if m, err := p.Metadata(); err == nil {

mm := map[string]string{}
for k, v := range m {
mm[k] = fmt.Sprintf("%v", v)

if k == "infrakit.logicalID" {
lid = mm[k]
}
}
all = append(all, mm)
}
}

_, tags := mergeTags(all...)

var logicalID instance.LogicalID
if lid != "" {
logicalID = instance.LogicalID(lid)
}

instance := instance.Description{
ID: id,
LogicalID: &logicalID,
Tags: tags,
}

if properties {

// from each item, get its actual URL and reconstruct the spec...
locations := map[string]URL{}

for _, p := range parts {
locations[p.Name()] = URL(p.URL().String())
}

prop := Properties{
ID: &id,
Locations: locations,
}

if any, err := types.AnyValue(&prop); err == nil {
instance.Properties = any
}
}

instances = append(instances, instance)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 41da4a601bbb18514c61ebaed12a229098ddcd3e