github-vet / github-vet/rangeloop-pointer-findings
dkyaorui/DosMq: mq/mq.go; 20 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [dkyaorui/DosMq](https://www.github.com/dkyaorui/DosMq) at [mq/mq.go](https://github.com/dkyaorui/DosMq/blob/eba73c4601605fa5f857acccccfb78c93ae5f89c/mq/mq.go#L150-L169)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable subscriber used in defer or goroutine at line 156
[Click here to see the code in its original context.](https://github.com/dkyaorui/DosMq/blob/eba73c4601605fa5f857acccccfb78c93ae5f89c/mq/mq.go#L150-L169)
Click here to show the 20 line(s) of Go which triggered the analyzer.
```go
for _, subscriber := range subscribers {
wg.Add(1)
go func() {
defer wg.Done()
var req *http.Request
var err error
switch strings.ToUpper(subscriber.Method) {
case http.MethodGet:
req, err = methodGetRequest(message, subscriber)
case http.MethodPost:
req, err = methodPostRequest(message, subscriber)
}
if err != nil {
log.Errorf("err:%+v", errors.WithMessage(err, "new request fail"))
return
}
c := &http.Client{}
_, err = c.Do(req)
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: eba73c4601605fa5f857acccccfb78c93ae5f89c
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.