github-vet / github-vet/rangeloop-pointer-findings

huanglaoxie0503/NewsSpider: engine/concurrent.go; 4 LoC

Open
#10,962 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [huanglaoxie0503/NewsSpider](https://www.github.com/huanglaoxie0503/NewsSpider) at [engine/concurrent.go](https://github.com/huanglaoxie0503/NewsSpider/blob/0482f32ece1b74ec5306fb48dcd59e75ff3c5f9d/engine/concurrent.go#L47-L50)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable item used in defer or goroutine at line 49

[Click here to see the code in its original context.](https://github.com/huanglaoxie0503/NewsSpider/blob/0482f32ece1b74ec5306fb48dcd59e75ff3c5f9d/engine/concurrent.go#L47-L50)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for _, item := range result.Items {
// 每一个 item 开一个 goroutine
go func() { c.ItemChan <- item }()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0482f32ece1b74ec5306fb48dcd59e75ff3c5f9d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.