github-vet / github-vet/rangeloop-pointer-findings

TicketsBot/worker: bot/autoclose/autoclose.go; 41 LoC

Open
#10,936 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TicketsBot/worker](https://www.github.com/TicketsBot/worker) at [bot/autoclose/autoclose.go](https://github.com/TicketsBot/worker/blob/d32cf6ccef3a3e3ab13ca509091738ae7f3ee3f4/bot/autoclose/autoclose.go#L21-L61)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable ticket used in defer or goroutine at line 24

[Click here to see the code in its original context.](https://github.com/TicketsBot/worker/blob/d32cf6ccef3a3e3ab13ca509091738ae7f3ee3f4/bot/autoclose/autoclose.go#L21-L61)

Click here to show the 41 line(s) of Go which triggered the analyzer.

```go
for ticket := range ch {
go func() {
// get worker
worker, err := buildContext(ticket, cache)
if err != nil {
sentry.Error(err)
return
}

// get ticket
ticket, err := dbclient.Client.Tickets.Get(ticket.TicketId, ticket.GuildId)
if err != nil {
sentry.Error(err)
return
}

// verify ticket exists + prevent potential panic
if ticket.ChannelId == nil {
return
}

// get self member
self, err := worker.GetGuildMember(ticket.GuildId, worker.BotId)
if err != nil {
// We are no longer in the guild and can exclude all tickets
if restError, ok := err.(request.RestError); ok && restError.ErrorCode == 403 {
if err := dbclient.Client.AutoCloseExclude.ExcludeAll(ticket.GuildId); err != nil {
sentry.Error(err)
}
}

sentry.Error(err)
return
}

// get premium status
premiumTier := utils.PremiumClient.GetTierByGuildId(ticket.GuildId, true, worker.Token, worker.RateLimiter)

logic.CloseTicket(worker, ticket.GuildId, *ticket.ChannelId, 0, self, &AutoCloseReason, true, premiumTier >= premium.Premium)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d32cf6ccef3a3e3ab13ca509091738ae7f3ee3f4

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.