hashicorp/nomad: nomad/structs/services.go; 5 LoC

Found a possible issue in [hashicorp/nomad](https://www.github.com/hashicorp/nomad) at [nomad/structs/services.go](https://github.com/hashicorp/nomad/blob/7a5ac679d24b262d63038e42a6ded25bf740adba/nomad/structs/services.go#L1141-L1145)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 1142 passes reference to upB to third-party code

[Click here to see the code in its original context.](https://github.com/hashicorp/nomad/blob/7a5ac679d24b262d63038e42a6ded25bf740adba/nomad/structs/services.go#L1141-L1145)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, upB := range b {
if upA.Equals(&upB) {
continue LOOP
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(Equals, 1)" -> {"(EqualSid, 2)";}
"(EqualSid, 2)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7a5ac679d24b262d63038e42a6ded25bf740adba

Start with nomad/structs/services.go at lines 1141-1145, then inspect Equals and EqualSid using the linked commit. Determine whether passing the range variable address can cause an actual issue or whether the behavior is safe. Record the finding as Bug, Mitigated, or Desirable Behavior using the issue's requested reaction classification.

Written by the indexing model from the issue text.