github-vet / github-vet/rangeloop-pointer-findings
SebastiaanKlippert/aws-beanstalk-sqs-daemon: sqsd/sqsd.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [SebastiaanKlippert/aws-beanstalk-sqs-daemon](https://www.github.com/SebastiaanKlippert/aws-beanstalk-sqs-daemon) at [sqsd/sqsd.go](https://github.com/SebastiaanKlippert/aws-beanstalk-sqs-daemon/blob/dccf30d42090c12b44ad92d9abbd41f75a0aa1e2/sqsd/sqsd.go#L81-L101)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable msg used in defer or goroutine at line 92
[Click here to see the code in its original context.](https://github.com/SebastiaanKlippert/aws-beanstalk-sqs-daemon/blob/dccf30d42090c12b44ad92d9abbd41f75a0aa1e2/sqsd/sqsd.go#L81-L101)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for _, msg := range out.Messages {
c.logf("received queue message with ID %s\n", aws.StringValue(msg.MessageId))
for c.openRequests.Get() >= c.MaxConnections {
time.Sleep(10 * time.Millisecond)
}
c.openRequests.Add(1)
go func() {
defer c.openRequests.Add(-1)
if err := c.sendHTTP(msg); err != nil {
log.Printf("error handling message %s: %s\n", aws.StringValue(msg.MessageId), err)
} else {
if err := c.deleteFromQueue(msg); err != nil {
log.Printf("error deleting message %s from queue: %s\n", aws.StringValue(msg.MessageId), err)
}
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: dccf30d42090c12b44ad92d9abbd41f75a0aa1e2
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.