github-vet / github-vet/rangeloop-pointer-findings
codeready-toolchain/host-operator: pkg/controller/nstemplatetier/nstemplatetier_controller.go; 27 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [codeready-toolchain/host-operator](https://www.github.com/codeready-toolchain/host-operator) at [pkg/controller/nstemplatetier/nstemplatetier_controller.go](https://github.com/codeready-toolchain/host-operator/blob/7c018f149dd050acd072d15a910043616131d301/pkg/controller/nstemplatetier/nstemplatetier_controller.go#L262-L288)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/codeready-toolchain/host-operator/blob/7c018f149dd050acd072d15a910043616131d301/pkg/controller/nstemplatetier/nstemplatetier_controller.go#L262-L288)
Click here to show the 27 line(s) of Go which triggered the analyzer.
```go
for _, tur := range templateUpdateRequests.Items {
logger.Info("checking templateUpdateRequest", "name", tur.Name, "deleted", util.IsBeingDeleted(&tur))
if util.IsBeingDeleted(&tur) {
// ignore when already being deleted
logger.Info("skipping TemplateUpdateRequest as it is already being deleted", "name", tur.Name)
continue
}
// delete when in `complete=true` (reason=updated) or when in `complete=false/reason=failed` status conditions
if condition.IsTrue(tur.Status.Conditions, toolchainv1alpha1.TemplateUpdateRequestComplete) ||
(condition.IsFalseWithReason(tur.Status.Conditions, toolchainv1alpha1.TemplateUpdateRequestComplete, toolchainv1alpha1.TemplateUpdateRequestUnableToUpdateReason) &&
maxUpdateFailuresReached(tur, r.config.GetMasterUserRecordUpdateFailureThreshold())) {
if err := r.incrementCounters(logger, tier, tur); err != nil {
return -1, false, err
}
if err := r.client.Delete(context.TODO(), &tur); err != nil {
if errors.IsNotFound(err) {
logger.Info("skipping failed TemplateUpdateRequest as it was already deleted", "name", tur.Name)
continue
}
return -1, false, errs.Wrapf(err, "unable to delete the TemplateUpdateRequest resource '%s'", tur.Name)
}
// will exit the reconcile loop
return -1, true, nil
}
count++
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {IsBeingDeleted 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 7c018f149dd050acd072d15a910043616131d301
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.