github-vet / github-vet/rangeloop-pointer-findings
1egoman/slick: commands.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [1egoman/slick](https://www.github.com/1egoman/slick) at [commands.go](https://github.com/1egoman/slick/blob/dabd69ddebbc62b6c7f915b802df55c9376fa0d7/commands.go#L680-L686)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to channel was used in a composite literal at line 682
[Click here to see the code in its original context.](https://github.com/1egoman/slick/blob/dabd69ddebbc62b6c7f915b802df55c9376fa0d7/commands.go#L680-L686)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, channel := range state.ActiveConnection().Channels() {
if channel.Name == channelName {
state.ActiveConnection().SetSelectedChannel(&channel)
setChannel = true
break
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: dabd69ddebbc62b6c7f915b802df55c9376fa0d7
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the referenced commands.go lines 680-686 and read the linked range-loop-capture classification guidance. Review the analyzer message in context, then leave the appropriate reaction on the issue; completion is the classification reaction being recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100