github-vet / github-vet/rangeloop-pointer-findings

evergreen-ci/cedar: model/cost_report_data.go; 4 LoC

Open
#10,457 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [evergreen-ci/cedar](https://www.github.com/evergreen-ci/cedar) at [model/cost_report_data.go](https://github.com/evergreen-ci/cedar/blob/f1c2987946fe6bc21a9cd478ed14cf982beda259/model/cost_report_data.go#L35-L38)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to p is reassigned at line 37

[Click here to see the code in its original context.](https://github.com/evergreen-ci/cedar/blob/f1c2987946fe6bc21a9cd478ed14cf982beda259/model/cost_report_data.go#L35-L38)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for _, p := range c.Projects {
p.refresh()
c.projects[p.Name] = &p
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f1c2987946fe6bc21a9cd478ed14cf982beda259

Contributor guide

No contributing guide indexed for this repository

Research direction

Review model/cost_report_data.go at lines 35-38 and compare the analyzer's range-loop pointer finding with the surrounding code. Determine whether the reported behavior is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.