github-vet / github-vet/rangeloop-pointer-findings
sanrentai/easyrpc: xclient/xclient.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [sanrentai/easyrpc](https://www.github.com/sanrentai/easyrpc) at [xclient/xclient.go](https://github.com/sanrentai/easyrpc/blob/e7b04bd90efb18b0154263bbd251cbe6e1993022/xclient/xclient.go#L87-L107)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable rpcAddr used in defer or goroutine at line 95
[Click here to see the code in its original context.](https://github.com/sanrentai/easyrpc/blob/e7b04bd90efb18b0154263bbd251cbe6e1993022/xclient/xclient.go#L87-L107)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for _, rpcAddr := range servers {
wg.Add(1)
go func() {
defer wg.Done()
var clonedReply interface{}
if reply != nil {
clonedReply = reflect.New(reflect.ValueOf(reply).Elem().Type()).Interface()
}
err := xc.call(rpcAddr, ctx, serviceMethod, args, clonedReply)
mu.Lock()
if err != nil && e == nil {
e = err
cancel() // if any call failed, cancel unfinished calls
}
if err == nil && !replyDone {
reflect.ValueOf(reply).Elem().Set(reflect.ValueOf(clonedReply).Elem())
replyDone = true
}
mu.Unlock()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: e7b04bd90efb18b0154263bbd251cbe6e1993022
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.