github-vet / github-vet/rangeloop-pointer-findings

tsyrul-alexander/xz-data-api: storage/pq/data_storage.go; 5 LoC

Open
#10,431 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tsyrul-alexander/xz-data-api](https://www.github.com/tsyrul-alexander/xz-data-api) at [storage/pq/data_storage.go](https://github.com/tsyrul-alexander/xz-data-api/blob/710212ab5d8846e3be4216c04bbd746878bd6687/storage/pq/data_storage.go#L105-L109)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to r was used in a composite literal at line 107

[Click here to see the code in its original context.](https://github.com/tsyrul-alexander/xz-data-api/blob/710212ab5d8846e3be4216c04bbd746878bd6687/storage/pq/data_storage.go#L105-L109)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, r := range rows {
list = append(list, &address.City{
Lookup: ds.getLookupValue(&r, "City"),
})
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 710212ab5d8846e3be4216c04bbd746878bd6687

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at storage/pq/data_storage.go lines 105-109 and read the surrounding range loop and getLookupValue usage. Determine whether taking a reference to r in this composite literal is a real bug, mitigated, or desirable behavior, then record the classification with the requested reaction; no test or patch is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
database
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.