github-vet / github-vet/rangeloop-pointer-findings
glennzw/phishPaste: phishpaste.go; 5 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [glennzw/phishPaste](https://www.github.com/glennzw/phishPaste) at [phishpaste.go](https://github.com/glennzw/phishPaste/blob/0cf03cfdc09efcc7a98c8d6a47c0383c4e5caba2/phishpaste.go#L160-L164)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/glennzw/phishPaste/blob/0cf03cfdc09efcc7a98c8d6a47c0383c4e5caba2/phishpaste.go#L160-L164)
Click here to show the 5 line(s) of Go which triggered the analyzer.
```go
for _, a := range newAttachments {
a.Id = 0
a.TemplateId = newTemplate.Id // We grab the ID of the freshly inserted new template
DB.Create(&a) // And insert each attachment
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Create 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0cf03cfdc09efcc7a98c8d6a47c0383c4e5caba2
Contributor guide
No contributing guide indexed for this repository
Research direction
Open phishpaste.go at lines 160-164 and inspect the surrounding use of newAttachments and DB.Create. Compare the analyzer's callgraph notes with the repository context, then classify the finding by leaving the requested Bug, Mitigated, or Desirable Behavior reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100