github-vet / github-vet/rangeloop-pointer-findings
liugjin/hmu2300: app/appmanager/server.go; 56 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [liugjin/hmu2300](https://www.github.com/liugjin/hmu2300) at [app/appmanager/server.go](https://github.com/liugjin/hmu2300/blob/0765beb1e9b8a93445b6348a438288d0dbfc4ca1/app/appmanager/server.go#L235-L290)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable suex used in defer or goroutine at line 277
[Click here to see the code in its original context.](https://github.com/liugjin/hmu2300/blob/0765beb1e9b8a93445b6348a438288d0dbfc4ca1/app/appmanager/server.go#L235-L290)
Click here to show the 56 line(s) of Go which triggered the analyzer.
```go
for _, suex := range sus {
if suex.SU.ID == suid {
for _, ch := range suex.Channels {
if ch.ID == chid {
port := ""
protocol := ""
var baudRate int32
for _, sp := range mu.SamplePorts {
for _, su := range sp.SampleUnits {
if su.ID == suid {
port = sp.Setting.Port
baudRate = sp.Setting.BaudRate
protocol = sp.Protocol
}
}
}
// send command
result, err := suex.CommonCommand(port, protocol, suid, chid, baudRate, p.Parameters)
if err != nil {
return "", errors.As(err, port, protocol, suid, chid, baudRate, p.Parameters)
}
// check for lock singal
buscfg := sys.GetBusManagerCfg()
for _, signal := range buscfg.AutoLock {
ids := strings.Split(signal.Topic, "/")
if len(ids) != 2 {
continue
}
// check id
if suid == ids[0] && chid == ids[1] {
// coincident
go func() {
time.Sleep(time.Second * 2)
// set value
var para public.CommandParameter
para.Value = signal.SetValue
r, err := suex.CommonCommand(port, protocol, suid, chid, baudRate, para)
log.Debugf("auto lock set value result: %s, %s", r, err)
}()
break
}
}
log.Debugf("port {%s}, protocol {%s}, channel {%s}, value {%v} command result: {%s}", port, protocol, chid, p.Parameters, result)
return result, nil
}
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0765beb1e9b8a93445b6348a438288d0dbfc4ca1
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.