github-vet / github-vet/rangeloop-pointer-findings
kaspernissen/automation_night_demo: coreos-kubernetes/multi-node/aws/vendor/github.com/lsegal/gucumber/runner.go; 59 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kaspernissen/automation_night_demo](https://www.github.com/kaspernissen/automation_night_demo) at [coreos-kubernetes/multi-node/aws/vendor/github.com/lsegal/gucumber/runner.go](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/lsegal/gucumber/runner.go#L289-L347)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable step used in defer or goroutine at line 310
[Click here to see the code in its original context.](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/lsegal/gucumber/runner.go#L289-L347)
Click here to show the 59 line(s) of Go which triggered the analyzer.
```go
for _, step := range s.Steps {
errCount := len(t.errors)
found := false
if !skipping && !t.Failed() {
done := make(chan bool)
go func() {
defer func() {
c.Results = append(c.Results, RunnerResult{t, f, s})
if t.Skipped() {
c.SkipCount++
skipping = true
clr = clrYellow
} else if t.Failed() {
c.FailCount++
clr = clrRed
}
done <- true
}()
f, err := c.Execute(t, step.Text, string(step.Argument))
if err != nil {
t.Error(err)
}
found = f
if !f {
t.Skip("no match function for step")
}
}()
<-done
}
if skipping && !found {
cstep := step
c.Unmatched = append(c.Unmatched, &cstep)
}
if !isExample {
c.fileLine(clr, " %s %s", step.Filename, step.Line,
s.LongestLine(), step.Type, step.Text)
if len(step.Argument) > 0 {
if !step.Argument.IsTabular() {
c.line(clrWhite, ` """`)
}
for _, l := range strings.Split(string(step.Argument), "\n") {
c.line(clrWhite, " %s", l)
}
if !step.Argument.IsTabular() {
c.line(clrWhite, ` """`)
}
}
}
if len(t.errors) > errCount {
c.line(clrRed, "\n"+t.errors[len(t.errors)-1].message)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 7fb1955971933f4a348987ee2d3e0df4587978bb
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.