github-vet / github-vet/rangeloop-pointer-findings
puyangsky/PKU-Kubernetes: pkg/cloudprovider/providers/aws/aws.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [puyangsky/PKU-Kubernetes](https://www.github.com/puyangsky/PKU-Kubernetes) at [pkg/cloudprovider/providers/aws/aws.go](https://github.com/puyangsky/PKU-Kubernetes/blob/82efc9291d4771781c738a3753c855e1e499e5bb/pkg/cloudprovider/providers/aws/aws.go#L2695-L2713)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to securityGroupID is reassigned at line 2697
[Click here to see the code in its original context.](https://github.com/puyangsky/PKU-Kubernetes/blob/82efc9291d4771781c738a3753c855e1e499e5bb/pkg/cloudprovider/providers/aws/aws.go#L2695-L2713)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for securityGroupID := range securityGroupIDs {
request := &ec2.DeleteSecurityGroupInput{}
request.GroupId = &securityGroupID
_, err := s.ec2.DeleteSecurityGroup(request)
if err == nil {
delete(securityGroupIDs, securityGroupID)
} else {
ignore := false
if awsError, ok := err.(awserr.Error); ok {
if awsError.Code() == "DependencyViolation" {
glog.V(2).Infof("Ignoring DependencyViolation while deleting load-balancer security group (%s), assuming because LB is in process of deleting", securityGroupID)
ignore = true
}
}
if !ignore {
return fmt.Errorf("error while deleting load balancer security group (%s): %v", securityGroupID, err)
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 82efc9291d4771781c738a3753c855e1e499e5bb
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.