github-vet / github-vet/rangeloop-pointer-findings
zvchain/zvchain: middleware/notify/topic.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [zvchain/zvchain](https://www.github.com/zvchain/zvchain) at [middleware/notify/topic.go](https://github.com/zvchain/zvchain/blob/1d97c82f2cbba7871455055b5b144716e7aa8ca1/middleware/notify/topic.go#L77-L94)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable h used in defer or goroutine at line 88
[Click here to see the code in its original context.](https://github.com/zvchain/zvchain/blob/1d97c82f2cbba7871455055b5b144716e7aa8ca1/middleware/notify/topic.go#L77-L94)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for _, h := range topic.handlers {
if withRecover {
go func() {
defer func() {
if r := recover(); r != nil {
types.MiddleWareLogger.Errorf("error:%v\n", r)
s := debug.Stack()
types.MiddleWareLogger.Errorf(string(s))
}
}()
h(message)
}()
} else {
go h(message)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1d97c82f2cbba7871455055b5b144716e7aa8ca1
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.