tczekajlo/kube-consul-register: controller/pods/controller.go; 16 LoC

Found a possible issue in [tczekajlo/kube-consul-register](https://www.github.com/tczekajlo/kube-consul-register) at [controller/pods/controller.go](https://github.com/tczekajlo/kube-consul-register/blob/8b856a437101f09bcd21896305be17bebe208ed4/controller/pods/controller.go#L140-L155)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/tczekajlo/kube-consul-register/blob/8b856a437101f09bcd21896305be17bebe208ed4/controller/pods/controller.go#L140-L155)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for _, pod := range pods.Items {
podInfo := &PodInfo{}
podInfo.save(&pod)

// If miss or consul.register/enabled annotation is set on `false` then skip pod
if !podInfo.isRegisterEnabled() {
continue
}

for _, container := range podInfo.ContainerStatuses {
serviceID := fmt.Sprintf("%s-%s", podInfo.Name, container.Name)
addedServices[serviceID] = true
}

podsInCluster = append(podsInCluster, podInfo) // nolint: megacheck
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {save 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8b856a437101f09bcd21896305be17bebe208ed4

Read controller/pods/controller.go, especially lines 140-155, and inspect how podInfo.save and the later pod data are used. Determine whether the range-loop handling causes an actual bug, then classify the finding as Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction; the issue provides no failing test or requested code change.

Written by the indexing model from the issue text.