github-vet / github-vet/rangeloop-pointer-findings
cf-platform-eng/kibosh: pkg/k8s/cluster.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cf-platform-eng/kibosh](https://www.github.com/cf-platform-eng/kibosh) at [pkg/k8s/cluster.go](https://github.com/cf-platform-eng/kibosh/blob/fbf47f9704c001b6ba713dcafe3e1f812f053679/pkg/k8s/cluster.go#L419-L430)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to item was used in a composite literal at line 427
[Click here to see the code in its original context.](https://github.com/cf-platform-eng/kibosh/blob/fbf47f9704c001b6ba713dcafe3e1f812f053679/pkg/k8s/cluster.go#L419-L430)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, item := range list.Items {
// Find RS associated with deployment
newReplicaSet, err := deploymentutil.GetNewReplicaSet(&item, cluster.GetClient().AppsV1())
if err != nil || newReplicaSet == nil {
return nil, err
}
newDeployment := Deployment{
newReplicaSet,
&item,
}
deployments.Items = append(deployments.Items, newDeployment)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: fbf47f9704c001b6ba713dcafe3e1f812f053679
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.