github-vet / github-vet/rangeloop-pointer-findings

integr8ly/delorean: cmd/productTests.go; 29 LoC

Open
#10,064 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [integr8ly/delorean](https://www.github.com/integr8ly/delorean) at [cmd/productTests.go](https://github.com/integr8ly/delorean/blob/8eff083bea74529b25f17ff0ad134302471e4486/cmd/productTests.go#L137-L165)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable testContainer used in defer or goroutine at line 158

[Click here to see the code in its original context.](https://github.com/integr8ly/delorean/blob/8eff083bea74529b25f17ff0ad134302471e4486/cmd/productTests.go#L137-L165)

Click here to show the 29 line(s) of Go which triggered the analyzer.

```go
for _, testContainer := range c.tests {
if testContainer.ImagePullSecret != "" {
if os.Getenv(testContainer.ImagePullSecret) == "" {
fmt.Println(fmt.Sprintf("[%s] ImagePullSecret %s defined in configuration but no value found", testContainer.Name, testContainer.ImagePullSecret))
continue
}
fmt.Println(fmt.Sprintf("[%s] Creating secret %s", testContainer.Name, testContainer.ImagePullSecret))
err = utils.CreateDockerSecret(c.clientset, parseSecretName(testContainer.ImagePullSecret), c.namespace, os.Getenv(testContainer.ImagePullSecret))
if err != nil {
return err
}
}
wg.Add(1)
go func(t *TestContainer) {
defer wg.Done()
fmt.Println(fmt.Sprintf("[%s] Start test container", t.Name))
ok, err := c.runTestContainer(ctx, t)
if err != nil {
fmt.Println(fmt.Sprintf("[%s] Error when run test container: %v", t.Name, err))
}
if ok {
testContainer.Success = true
fmt.Println(fmt.Sprintf("[%s] Test container finished successfully", t.Name))
} else {
testContainer.Success = false
fmt.Println(fmt.Sprintf("[%s] Test container failed", t.Name))
}
}(testContainer)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8eff083bea74529b25f17ff0ad134302471e4486

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.