github-vet / github-vet/rangeloop-pointer-findings
nethesis/windmill: ronzinante/methods/sessions.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [nethesis/windmill](https://www.github.com/nethesis/windmill) at [ronzinante/methods/sessions.go](https://github.com/nethesis/windmill/blob/502cc5ef638f668dfdac1dd79342c46741b13a83/ronzinante/methods/sessions.go#L95-L104)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/nethesis/windmill/blob/502cc5ef638f668dfdac1dd79342c46741b13a83/ronzinante/methods/sessions.go#L95-L104)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, s := range sessions {
if s.VpnIp == "" {
// call helper to get ip
out, _ := exec.Command("/opt/windmill/helpers/windmill-get-ip", s.ServerId).Output()
s.VpnIp = string(out)
// save vpn ip
db.Save(&s)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Save 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 502cc5ef638f668dfdac1dd79342c46741b13a83
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.