github-tools / github-tools/github

response will be undefined for 404 endpoint

Open
#495 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
809
PR merge metrics
No merged PRs in 30d

Description

https://github.com/github-tools/github/blob/24223f7a51ba935f1c86ffd552dac20e8f3e359d/lib/Requestable.js#L187

In the above code **response** will be undefined if the request is for a non-existing endpoint (which will result in 404 response).

In-order to re-produce invoke getSha() method for a non-existing in the repository

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.