github-community-projects / github-community-projects/safe-settings
Validation check hangs if multiple suborgs matched repositories
- Dominant language
- JavaScript
- Stars
- 921
- Forks
- 226
- Avg merge
- 18h 3m
- Merged PRs (30d)
- 14
Description
## Problem Description
### What is actually happening
During app validation, if the new logic in https://github.com/github/safe-settings/commit/a692dbf506782c16fcf1cb995548cc6f74ced02a catches a match for multiple suborgs, the check is not correctly failed.
### What is the expected behavior
- The check fails with the appropriate error message.
- Optionally, a PR comment is created
### Error output, if available
```
2025-03-18T03:44:43.962000: ERROR (event): NOPCOMMAND {"type":"ERROR","plugin":"getSubOrgConfigs","repo":"safe-settings-config","endpoint":"","body":"","action":{"msg":"Error: Multiple suborg configs for devframework.bom-test-project in .github/suborgs/hcs-devfw.yml and .github/suborgs/hcs-devframework.yml","additions":null,"modifications":null,"deletions":null}}
```
## Context
### Are you using the hosted instance of probot/settings or running your own?
Running our own
### If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com
#### Version of probot/settings
I believe we are on 2.1.16, but I'm not 100% sure.
#### Version of GitHub Enterprise
N/A (on GitHub Enterprise Cloud)
Contributor guide
Assessment
This issue has not been assessed yet.