github-community-projects / github-community-projects/safe-settings

Excluding labels will still show as deletion

Open
#764 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
921
Forks
226
Avg merge
18h 3m
Merged PRs (30d)
14

Description

## Problem Description

When configuring `labels.exclude` to exclude some/all labels it will still show as a Deletion in PR context. After some looking into the code i think it shouldn't actually run the delete API call. (in NOP mode it also doesn't print the delete message) [Link to exclude code block](https://github.com/github/safe-settings/blob/main-enterprise/lib/plugins/labels.js#L84).

### What is actually happening

- Showing labels that should be exluded in the deletion column!

### What is the expected behavior

- Do not show any excluded labels in the PR Comment.

## Context

### Are you using the hosted instance of probot/settings or running your own?

self-hosted

### If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

#### Version of probot/settings

2.1.16

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.