github-community-projects / github-community-projects/safe-settings

Cron Schedule not recognizing changes to Pull Request settings

Open
#528 1 comment 2 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
921
Forks
226
Avg merge
18h 3m
Merged PRs (30d)
14

Description

## Problem Description
After disabling/enabling allow merge commits or allow rebase merging, the settings do not change automatically, even if there is a change compared to the actual configuration.
However, when changing another field, the change is recognized and the cron job also changes the Pull Request settings.

### What is actually happening
Changes to Pull Request settings are not recognized as changes.

### What is the expected behavior
When changing pull request changes, in the next cron schedule, the settings should be seen as changed.

## Context

### Are you using the hosted instance of probot/settings or running your own?
Running our own

### If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com

#### Version of probot/settings
2.0.23-rc.11

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.