github-community-projects / github-community-projects/safe-settings

Warning for new GH feature in beta

Open
#315 4 comments 4 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
921
Forks
226
Avg merge
18h 3m
Merged PRs (30d)
14

Description

Hi folks, just creating this issue as a warning for an upcoming feature from GitHub

https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization

Setting a team as a security manager (as on org-wide setting, so out of "scope" of safe-settings app) causes the relevant team to be added to every repository in the organization. This causes safe-settings team differ to always identify out-of-sync teams for every repo, causing re-sync for every repo as well. Further, the attempted sync will fail with:

```
error calling find for Teams HttpError: You cannot remove repositories from a security manager team. for repo:
```

I think adding this team to global teams in settings.yaml will mitigate this (though I will need to check tomorrow), but there is no clear way to keep these settings and security managers in sync as of now

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.