github-community-projects / github-community-projects/safe-settings

commentmessage can be too big and fail

Open
#245 2 comments 4 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
921
Forks
226
Avg merge
18h 3m
Merged PRs (30d)
14

Description

## Problem Description
There is a limit to comment in checks api summary. When there are a large number of changes (like changing a setting across all repos), this API call can fail, casuing no completion status to ever be posted

### What is actually happening
Check run stays pending

### What is the expected behavior
Check run completes

A simple solution we are using is to just make sure the comment fits in summary limits
![image](https://user-images.githubusercontent.com/16494982/179824071-40b2e8e2-4fad-4fc3-ac8c-1d42c5a9008a.png)
but its not super pretty. I can implenent this solution if we want

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.