github-community-projects / github-community-projects/safe-settings

Repository branch protection ruleset not getting removed

Open
#1,002 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
921
Forks
226
Avg merge
18h 3m
Merged PRs (30d)
14

Description

## Problem Description
Repository ruleset created in repository from SubOrg yaml is not getting removed if repository condition in SubOrg file gets changed
### What is actually happening
Steps to reproduce:
Create a SubOrg settings file with branch protection ruleset, use custom property to map repos, push changes
Add a repository add same custom property value you mentioned in SubOrg file
verify branch protection ruleset gets created at repo level
now edit SubOrg settings and update custom property value used to map repos

Expected is as repo no longer matches the custom property value in SubOrg file, ruleset created previously should get removed
### What is the expected behavior
Ruleset still present in repo settings
### Error output, if available

```

```

## Context

### Are you using the hosted instance of probot/settings or running your own?

### If running your own instance, are you using it with github.com or GitHub Enterprise?

#### Version of probot/settings

#### Version of GitHub Enterprise

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.