gitcoinco / gitcoinco/web

zksync: The transactions showing the approve txn

Open
#9,986 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.8k
Forks
776
PR merge metrics
No merged PRs in 30d

Description

**User Story:**
As a
I want to
So that

**Acceptance Criteria**
GIVEN
WHEN
THEN

The goal would be here to write up a script to fix these contributions which track the deposit and not the actual txn.

I'm not clear on how easy it would be to this but it would require writing up a script which would
- fetch all zksync txns
- check if they are actual transfers
- if not -> find the actual transfer update them

**Product & Design Links:**

**Tech Details:**

**Open Questions:**

**Notes/Assumptions:**
From @thelostone-mc's story in Jira:
So the update is that that weird zksync txn registering deposit happened only for the initial round we introduced l2

Double checked it myself by doing a deposit and making the payment

We store the txnid and not the deposit

lefterisjp | Rotki — 07/15/2021
i see but how can we reconcile this data to be the same?

thelostone-mc — Today at 6:15 PM
I've got this tracked internally and asked folks to get it bumped up but honestly it might take a week before folks can get to it / it can be picked up

lefterisjp | Rotki — Today at 6:16 PM
hey @thelostone-mc so which problem is this rn? Which is the problem we talk about? The transactions showing the approve, right? This is quite a problem for accounting.

More info here:

https://gitcoincore.slack.com/archives/C01H9H320CV/p1625750368344500

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.