gitcoinco / gitcoinco/web

upgrade web3.js

Open
#9,758 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.8k
Forks
776
PR merge metrics
No merged PRs in 30d

Description

### Description

In order to take advantage of the London fork, we need to upgrade web3.js to the latest version (1.5.1).

Release notes can be found here: https://github.com/ChainSafe/web3.js/releases?after=v1.0.0-beta.42

It doesn't look like there have been a huge amount of breaking changes, but we need to be sure to check what has changed on the minor/patch and update everything accordingly. The main change that we need to encompass is with regards to gasPrice (we need to switch to using maxFeePerGas and maxPriorityFeePerGas) or omit any mention from the tx's.

Upgrades will need to be made against any script that utilises web3.js:

- /app/assets/onepager/js/receive.js
- /app/assets/onepager/js/send.js
- /app/assets/v2/js/avatar_builder.js
- /app/assets/v2/js/board.js
- /app/assets/v2/js/cart.js
- /app/assets/v2/js/shared.js
- /app/assets/v2/js/wallet.js
- /app/assets/v2/js/event_ethdenver2019/kudos_bulk_receive.js
- /app/assets/v2/js/grants/_detail-component.js
- /app/assets/v2/js/grants/ingest-missing-contributions.js
- /app/assets/v2/js/grants/new_match.js
- /app/assets/v2/js/pages/bounty_details.js
- /app/assets/v2/js/pages/bounty_details2.js
- /app/assets/v2/js/pages/bounty_request_form.js
- /app/assets/v2/js/pages/bulk_payout.js
- /app/assets/v2/js/pages/change_bounty.js
- /app/assets/v2/js/pages/faucet_form.js
- /app/assets/v2/js/pages/increase_bounty.js
- /app/assets/v2/js/pages/kudos_bulk_receive.js
- /app/assets/v2/js/pages/kudos_receive.js
- /app/assets/v2/js/pages/kudos_send.js
- /app/assets/v2/js/pages/new_bounty.js
- /app/assets/v2/js/pages/onboard.js
- /app/assets/v2/js/pages/process_bounty.js
- /app/assets/v2/js/pages/process_faucet.js
- /app/assets/v2/js/pages/profile_tokens.js
- /app/assets/v2/js/pages/profile-trust.js
- /app/assets/v2/js/pages/tokens_settings.js
- /app/assets/v2/js/pages/bounty_detail/web3_modal.js
- /app/assets/v2/js/pages/cancel_bounty/ETH.js
- /app/assets/v2/js/pages/fulfill_bounty/ETH.js
- /app/assets/v2/js/quadraticlands/ql-web3.js
- /app/assets/v2/js/quadraticlands/stewards.js
- /app/assets/v2/js/quadraticlands/components/nav.js
- /app/assets/v2/js/quadraticlands/dashboard/governance.js
- /app/assets/v2/js/quadraticlands/mission/diplomacy/room.js
- /scripts/see_transaction.js
- /scripts/transfer_kudos.js
- /scripts/debug/check_approval_amount.js
- /scripts/debug/debug_bounty_details.js
- /scripts/debug/reprocess_bounty.js

### Acceptance Criteria

When all scripts utilising web3.py have been checked and updated according to the release notes and all regression tests pass

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.