gitcoinco / gitcoinco/web

Consider converting your scripts to proper POSIX shell syntax rather than bash

Open
#10,719 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.8k
Forks
776
PR merge metrics
No merged PRs in 30d

Description

Your scripts (`/scripts`) have a `.bash` extension which I find rather odd.
Bash, while compatible with POSIX introduces many non-standard 'features'. Please consider revising your scripts to proper POSIX strict syntax to ensure compatibility across different systems (e.g. Alpine and OpenBSD ship with shells other than bash and many individuals replace bash with more frugal and secure shells). Your support of bash also results in enforcing it as standard which promotes obese and insecure software (bash has hundreds, if not thousands and upwards of registered bugs).

Contributor guide

Open the contributing guide

Research direction

Review the scripts under /scripts and identify which syntax depends on bash rather than POSIX shell behavior. Check the scripts against the compatibility goal described for Alpine and OpenBSD, then verify that all scripts use proper POSIX syntax without changing their intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash, shell
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.