gitcoinco / gitcoinco/web

Improve running tests in CI

Open
#10,063 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.8k
Forks
776
PR merge metrics
No merged PRs in 30d

Description

Potential improvements in the CI workflow:

- use cypress github action for running cypress tests ( https://github.com/cypress-io/github-action )
- run testrpc as a service so that we don't need to start it explicitly before running the tests. Ganache-cli is available as a docker container, but it is unclear how to pass arguments to it. We would need to pass in: --mnemonic "${TEST_MNEMONIC}" --defaultBalanceEther 1000000000
- make sure we have a timeout for the cypress tests - we want to avoid that a hanging cypress test run eats up our CI minutes ( see https://github.com/cypress-io/github-action#timeouts ) - it has happened a few times for me that the tests hang
- store the test mnemonic and cypress project key in github secrets vault ( it is currently in the code )

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.