git-ecosystem / git-ecosystem/git-credential-manager
Review/Rationalise the environment and configuration options used by Bitbucket Cloud and DC
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 9.3k
- Forks
- 2.9k
- Avg merge
- 7d 1h
- Merged PRs (30d)
- 14
Description
Description
Currently the implemented support for Bitbucket Cloud and DC includes a duplicated set of configuration or environment options e.g.
credential.bitbucketDataCenterOAuthClientSecret vs credential.cloudOAuthClientSecret
GCM_BITBUCKET_DATACENTER_CLIENTID vs GCM_BITBUCKET_CLOUD_CLIENTID
Conceptually there should be no reason for duplicating the configuration options because the use of the target url in the configuration should be sufficient to differentiate between cloud vs DC.
e.g.
credential.http://bitbucket.org.oauthClientSecret vs credential.http://example.com/bitbucket.oauthClientSecret
However it is not as clear cut with the Environment variables, since they do not have the flexibility to target explicit urls, so they should probably stay distinct cloud vs DC.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying the Bitbucket Cloud and Data Center credential and environment options named in the issue, then compare how target URLs distinguish the services. Review the existing configuration behavior and decide which options can be rationalized while preserving distinct environment-variable handling; done means the supported options and their separation are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100