git-ecosystem / git-ecosystem/git-credential-manager

Clicking cancel on application authorize shows successful page instead of something else

Open
#1,553 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auth-issue
Dominant language
C#
Stars
9.3k
Forks
2.9k
Avg merge
7d 1h
Merged PRs (30d)
14

Description

Version

2.4.1

Operating system

Windows

OS version or distribution

Windows 10 Pro 19045

Git hosting provider(s)

Other - please describe below

Other hosting provider

Gitea

(Azure DevOps only) What format is your remote URL?

None

Can you access the remote repository directly in the browser?

Yes, I can access the repository

Expected behavior

Tested on try.gitea.io

To reproduce I created an empty repository.
I attempted to push using HTTPS with git for Windows version 2.43.0.windows.1
When the application opens a new tab on my browser I have the option to either authorize or cancel the "Git Credentials Manager"
When I click "cancel" a page opens some sort of page that confirms the operation was cancelled.

Actual behavior

A successful page saying the application was authorized is shown even when I click cancel in the scenario explained above.

313815019-7275307c-fffe-451d-bc76-a6cbfb9d902d
313814993-49993847-2b00-4894-9009-70a1eddaaaa0

Logs

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the HTTPS push reproduction against try.gitea.io using Git for Windows 2.43.0.windows.1, then follow the browser authorization flow when cancelling Git Credential Manager access. Done means cancellation produces a cancellation result rather than the successful authorization page.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, git
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.