gildas-lormeau / gildas-lormeau/SingleFile
Add attribute to record download errors (e.g. data-sf-original-src-down-error) when "save original URLs of embedded resources" is enabled
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 22.4k
- Forks
- 1.4k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 5
Description
Is your feature request related to a problem? Please describe.
img download error, but I can't fast find and fix they.
Describe the solution you'd like
some image download error, can you add attribute to save original link, and error tag.
can help me to find they and manually fix
Describe alternatives you've considered (optional)
// "/download/502.png" is unstable resources，some time is ok, some time is error.
<img src="/download/502.png">
--->
<img src="base64:null" data-singlefile-save-link="/download/502.png" data-singlefile-down-error="true">
by the way.
src = data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw== can use it as error tag?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the resource-download handling and the option for saving original URLs of embedded resources. Reproduce a failed image download like /download/502.png and inspect the generated HTML; done means failed resources retain an original-URL attribute and an error marker when the option is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100