gildas-lormeau / gildas-lormeau/SingleFile
Various Improvements
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 22.4k
- Forks
- 1.4k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 5
Description
**Just feedback, read only if you have time: Not the important**
1- by default the infobar icon, would be flashing for 3-5 seconds (switch between yellow and gray) and settles on Gray at the end to attract user attention.
Reason for the suggestion:
When a file is shared, or when the user open the file in far future they will notice the infobar icon. I have a concern that I would forget about it and it is hard to notice. Maybe it is just me.
However, I would advise against this IF you think the code which result in flashing the infobar icon might break in future browsers when the file is opened. The idea of Singlefile is to save an archival version of the file for digital preservation, in my humble STOOPID opinion, thus avoiding things that might cause issues.
unrelated suggestions:
2- The time/date variables are too limited, not fully customizable, if it is customizable then I am too stoopid to figure it out:
- I prefer how it is on Windows and AutoHotkey. they use a code/variable that looks like this:
hh:mmttd/M/yyyy
With that format the leading zero for month and day is removed and can be added by just adding anotherm/d. Additionally, thettadds the PM/AM and I can control which character I can put between each variable like/ . \ -_ ; :and to have the hours in 24H format I you can capitalize itHH
Windows/Autohotkey style is easier for not so technical users like me.
3- in the infobar I wanted to add Notes, saved date, and page title, I used the code below:
Page title: {page-title} \n Saved on: Wed Jul 10 2024 01:14:48 GMT+0200 (Central European Summer Time) \n \n Notes:
but it is hard to add notes, so I suggest the window for infobar contect would be multiple lines and accept new line by pressing enter to add notes in several lines.
4- Addition of a variable to add a link to SingleFile project in infobar and the version it was saved with.
The Reason for this suggestion: It will help promote SingleFile, and also, have a record of which version of SingleFile was used to save the webpage.
5- Lastly, if Template of the infobar content left empty, it will save in this format
Wed Jul 10 2024 01:14:48 GMT+0200 (Central European Summer Time)
I tried my best, but I couldn't replicate it, I wanted to add,
GMT+0200 (Central European Summer Time)
And
Wed
Jul
but I couldn't find any variable, I would appreciate it if you would tell me how to add the date in this format: 01:14:48AM 10/07/2024 GMT+0200 (Central European Summer Time) and in this format yyyy.mm.dd.hh.mmtt
Thank you for your hard work.
Originally posted by @StoopidoMan in https://github.com/gildas-lormeau/SingleFile/issues/1469#issuecomment-2219080931
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by separating the five suggestions: infobar flashing, date-format variables, multiline content, project/version variables, and the empty-template date format. The payload names no files or tests, so first inspect the infobar settings and template handling; the work is done only after a specific subset, behavior, and acceptance criteria are agreed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100